fix: Shift+Click on column header now triggers multi-column sort#543
Closed
fix: Shift+Click on column header now triggers multi-column sort#543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the multi-column sort part of #541.
Root cause:
NSTableViewswallows Shift+Click on column headers — thesortDescriptorsDidChangedelegate is never called when Shift is held. The existing multi-sort logic inhandleSortwas correct but unreachable.Fix: Added
SortableTableHeaderView(NSTableHeaderView subclass) that interceptsmouseDownwhen Shift is held, identifies the clicked column, and routes directly to the coordinator's multi-sort handler — bypassing NSTableView's broken Shift+Click behavior.Changes:
KeyHandlingTableView.swift— AddedSortableTableHeaderViewclassDataGridView.swift— Installed custom header view on table creationDataGridView+Sort.swift— AddedhandleShiftClickSortentry point for the header viewTest plan
ORDER BY name ASC, id ASC)name 1▲,id 2▼)